linux-kernel - [ti:ti-rt-linux-5.10.y 9021/9320] drivers/gpu/drm/omapdrm/omap_wb_cap.c:512:13: warning: variable 'ret' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 17 Sep 2021 16:26:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Benoit Parrot <bparrot@...com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Vignesh Raghavendra <vigneshr@...com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: [ti:ti-rt-linux-5.10.y 9021/9320]
 drivers/gpu/drm/omapdrm/omap_wb_cap.c:512:13: warning: variable 'ret' set
 but not used

Hi Benoit,

FYI, the error/warning still remains.

tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head:   716065a9435e7c06986b8497aa853a7b747a9570
commit: b5eff5a26c1aa3a3872533555a4678d510d07f87 [9021/9320] drm/omap: add WB support
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
        git fetch --no-tags ti ti-rt-linux-5.10.y
        git checkout b5eff5a26c1aa3a3872533555a4678d510d07f87
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/omapdrm/omap_wb_cap.c: In function 'stop_streaming':
>> drivers/gpu/drm/omapdrm/omap_wb_cap.c:512:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     512 |         int ret;
         |             ^~~


vim +/ret +512 drivers/gpu/drm/omapdrm/omap_wb_cap.c

   502	
   503	/*
   504	 * Stop the DMA engine. Any remaining buffers in the DMA queue are dequeued
   505	 * and passed on to the vb2 framework marked as STATE_ERROR.
   506	 */
   507	static void stop_streaming(struct vb2_queue *vq)
   508	{
   509		struct wbcap_dev *wbcap = vb2_get_drv_priv(vq);
   510		struct omap_drm_private *priv = wbcap->dev->drm_dev->dev_private;
   511		struct drm_crtc *crtc;
 > 512		int ret;
   513	
   514		log_dbg(wbcap, "Stopping WB\n");
   515		log_dbg(wbcap, "current state: %d\n", wbcap->state);
   516	
   517		wbcap->stopping = true;
   518		ret = wait_event_timeout(wbcap->event,
   519					 !wbcap->stopping,
   520					 msecs_to_jiffies(250));
   521	
   522		log_dbg(wbcap, "Returning VB2 buffers\n");
   523	
   524		if (priv->dispc_ops->wb_go_busy(priv->dispc))
   525			log_err(wbcap, "WARNING, WB BUSY when stopping\n");
   526	
   527		/* Release all active buffers */
   528		return_all_buffers(wbcap, VB2_BUF_STATE_ERROR);
   529	
   530		/* Disable vsync irq on the input crtc */
   531		crtc = priv->pipes[wb_inputs[wbcap->input].crtc_index].crtc;
   532		drm_crtc_vblank_put(crtc);
   533	
   534		priv->dispc_ops->runtime_put(priv->dispc);
   535	}
   536	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (77015 bytes)