linux-kernel - RE: [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001201d7abae$8d160a10$a7421e30$@codeaurora.org>
Date:   Fri, 17 Sep 2021 15:56:54 +0530
From:   <pillair@...eaurora.org>
To:     "'Stephen Boyd'" <swboyd@...omium.org>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <mathieu.poirier@...aro.org>,
        <ohad@...ery.com>, <p.zabel@...gutronix.de>, <robh+dt@...nel.org>
Cc:     <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <sibis@...eaurora.org>,
        <mpubbise@...eaurora.org>, <kuabhs@...omium.org>
Subject: RE: [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support



> -----Original Message-----
> From: Stephen Boyd <swboyd@...omium.org>
> Sent: Friday, September 17, 2021 11:56 AM
> To: Rakesh Pillai <pillair@...eaurora.org>; agross@...nel.org;
> bjorn.andersson@...aro.org; mathieu.poirier@...aro.org; ohad@...ery.com;
> p.zabel@...gutronix.de; robh+dt@...nel.org
> Cc: linux-arm-msm@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; sibis@...eaurora.org; mpubbise@...eaurora.org;
> kuabhs@...omium.org
> Subject: Re: [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280
> WPSS support
> 
> Quoting Rakesh Pillai (2021-09-16 09:55:52)
> > @@ -78,6 +84,10 @@ properties:
> >        Phandle reference to a syscon representing TCSR followed by the
> >        three offsets within syscon for q6, modem and nc halt registers.
> >
> > +  qcom,qmp:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: Reference to the AOSS side-channel message RAM.
> > +
> >    qcom,smem-states:
> >      $ref: /schemas/types.yaml#/definitions/phandle-array
> >      description: States used by the AP to signal the Hexagon core @@
> > -117,6 +127,33 @@ allOf:
> >          compatible:
> >            contains:
> >              enum:
> > +              - qcom,sc7280-wpss-pil
> > +    then:
> 
> Honestly I find this if/else to be a huge tangle. Why not split the binding so
> that each compatible is a different file? Then it is easier to read and see what
> properties to set.

Hi Stephen,
I will create a separate dt-bindings yaml file for sc7280-wpss-pil, which will avoid all such if-else conditions.

> 
> > +      properties:
> > +        interrupts-extended:
> > +          maxItems: 6
> > +          items:
> > +            - description: Watchdog interrupt
> > +            - description: Fatal interrupt
> > +            - description: Ready interrupt