linux-kernel - Re: [PATCH v2 0/2] Add a generic virtual thermal sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd347d14-0b42-f9ed-bf15-080c929e1cb7@linaro.org>
Date:   Fri, 17 Sep 2021 14:41:21 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Alexandre Bailon <abailon@...libre.com>, rui.zhang@...el.com,
        amitk@...nel.org
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        ben.tseng@...iatek.com, khilman@...libre.com, mka@...omium.org
Subject: Re: [PATCH v2 0/2] Add a generic virtual thermal sensor

On 17/09/2021 09:27, Alexandre Bailon wrote:
> This series add a virtual thermal sensor.
> It could be used to get a temperature using some thermal sensors.
> Currently, the supported operations are max, min and avg.
> The virtual sensor could be easily extended to support others operations.
> 
> Note:
> Currently, thermal drivers must explicitly register their sensors to make them
> available to the virtual sensor.
> This doesn't seem a good solution to me and I think it would be preferable to
> update the framework to register the list of each available sensors.

Why must the drivers do that ?

> Changes in v2:
> - Fix some warnings / errors reported by kernel test robot
> - rename some struct and functions with a more accurate name
> - update the dt bindings: rename type attribute to aggregation-function
> - factorize a little bit the aggregation functions
> 
> Alexandre Bailon (2):
>   dt-bindings: Add bindings for the virtual thermal sensor
>   thermal: add a virtual sensor to aggregate temperatures
> 
>  .../thermal/virtual,thermal-sensor.yaml       |  67 +++
>  drivers/thermal/Kconfig                       |   8 +
>  drivers/thermal/Makefile                      |   1 +
>  drivers/thermal/virtual-sensor.h              |  51 +++
>  drivers/thermal/virtual_sensor.c              | 400 ++++++++++++++++++
>  include/dt-bindings/thermal/virtual-sensor.h  |  15 +
>  6 files changed, 542 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/virtual,thermal-sensor.yaml
>  create mode 100644 drivers/thermal/virtual-sensor.h
>  create mode 100644 drivers/thermal/virtual_sensor.c
>  create mode 100644 include/dt-bindings/thermal/virtual-sensor.h
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog