linux-kernel - Re: [PATCH] dma: plx_dma: switch from 'pci_' to 'dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eeaee4a8-12d4-fb1d-bd4d-9cb3a60a3432@deltatee.com>
Date:   Fri, 17 Sep 2021 09:20:24 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Qing Wang <wangqing@...o.com>, Vinod Koul <vkoul@...nel.org>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma: plx_dma: switch from 'pci_' to 'dma_' API



On 2021-09-17 1:18 a.m., Qing Wang wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below.
> expression e1, e2;
> @@
> -    pci_set_dma_mask(e1, e2)
> +    dma_set_mask(&e1->dev, e2)
> 
> @@
> expression e1, e2;
> @@
> -    pci_set_consistent_dma_mask(e1, e2)
> +    dma_set_coherent_mask(&e1->dev, e2)
> 
> While at it, some 'dma_set_mask()/dma_set_coherent_mask()' have been
> updated to a much less verbose 'dma_set_mask_and_coherent()'.
> 
> This type of patches has been going on for a long time, I plan to 
> clean it up in the near future. If needed, see post from 
> Christoph Hellwig on the kernel-janitors ML:
> https://marc.info/?l=kernel-janitors&m=158745678307186&w=4
> 
> Signed-off-by: Qing Wang <wangqing@...o.com>

Looks good to me. Thanks.

Reviweed-by: Logan Gunthorpe <logang@...tatee.com>