linux-kernel - Re: [PATCH 2/4] regulator: dt-bindings: Add pm8008 regulator bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210917154818.GC4700@sirena.org.uk>
Date:   Fri, 17 Sep 2021 16:48:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Satya Priya <skakit@...eaurora.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>, mka@...omium.org,
        swboyd@...omium.org, Das Srinagesh <gurus@...eaurora.org>,
        David Collins <collinsd@...eaurora.org>, kgunda@...eaurora.org,
        Subbaraman Narayanamurthy <subbaram@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] regulator: dt-bindings: Add pm8008 regulator bindings

On Fri, Sep 17, 2021 at 04:15:36PM +0530, Satya Priya wrote:

> +    properties:
> +      reg:
> +        maxItems: 1
> +      regulator-name: true
> +      regulator-min-microvolt: true
> +      regulator-max-microvolt: true

You shouldn't be forcing these properties, it should be perfectly OK for
boards to have fixed voltages especially for example during bringup or
for debugging.

> +      qcom,min-dropout-voltage:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description:
> +          Specifies the minimum voltage in microvolts that the parent
> +          supply regulator must output, above the output of this
> +          regulator.

If this is needed in DT it should be a generic property since most
regulators have some requirement here however usually it's a fixed
property of the silicon and should therefore just gets set in the
regulator_desc as min_dropout_uV - I'd strongly recommend having a
default there even if there's some requirement for it to be set per
board.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)