linux-kernel - Re: [PATCH v2] mei: Remove usage of the deprecated "pci-dma-compat.h" API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3=0kJamjC3Fd_xHx==AXs-_k77gpYkhZz6VEa31K6iOQ@mail.gmail.com>
Date:   Sat, 18 Sep 2021 11:40:47 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     "Winkler, Tomas" <tomas.winkler@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        gregkh <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] mei: Remove usage of the deprecated "pci-dma-compat.h" API

On Sat, Sep 18, 2021 at 7:36 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> In [1], Christoph Hellwig has proposed to remove the wrappers in
> include/linux/pci-dma-compat.h.
>
> Some reasons why this API should be removed have been given by Julia
> Lawall in [2].
>
> Finally, Arnd Bergmann reminded that the documentation was updated 11 years
> ago to only describe the modern linux/dma-mapping.h interfaces and mark the
> old bus-specific ones as no longer recommended, see commit 216bf58f4092
> ("Documentation: convert PCI-DMA-mapping.txt to use the generic DMA API").
>
> A coccinelle script has been used to perform the needed transformation
> Only relevant parts are given below.
>
> @@
> expression e1, e2;
> @@
> -    pci_set_dma_mask(e1, e2)
> +    dma_set_mask(&e1->dev, e2)
>
> [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/
> [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> v2: Change Subject to be more explicit
>     Keep only relevant part of the coccinelle script
>     Try to improve the commit message to give some reason of why this change is done

Reviewed-by: Arnd Bergmann <arnd@...db.de>