linux-kernel - Re: [PATCH stable-5.4.y stable-5.10.y] btrfs: fix upper limit for max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YUXZIHWG97Pae1HG@kroah.com>
Date:   Sat, 18 Sep 2021 14:18:40 +0200
From:   Greg KH <greg@...ah.com>
To:     Anand Jain <anand.jain@...cle.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        linux-btrfs@...r.kernel.org,
        Alexander Tsvetkov <alexander.tsvetkov@...cle.com>,
        David Sterba <dsterba@...e.com>
Subject: Re: [PATCH stable-5.4.y stable-5.10.y] btrfs: fix upper limit for
 max_inline for page size 64K

On Thu, Sep 16, 2021 at 03:34:01PM +0800, Anand Jain wrote:
> Commit 6f93e834fa7c5faa0372e46828b4b2a966ac61d7 upstream.
> 
> The mount option max_inline ranges from 0 to the sectorsize (which is
> now equal to page size). But we parse the mount options too early and
> before the actual sectorsize is read from the superblock. So the upper
> limit of max_inline is unaware of the actual sectorsize and is limited
> by the temporary sectorsize 4096, even on a system where the default
> sectorsize is 64K.
> 
> Fix this by reading the superblock sectorsize before the mount option
> parse.
> 
> Reported-by: Alexander Tsvetkov <alexander.tsvetkov@...cle.com>
> CC: stable@...r.kernel.org # 5.4+
> Signed-off-by: Anand Jain <anand.jain@...cle.com>
> Reviewed-by: David Sterba <dsterba@...e.com>
> Signed-off-by: David Sterba <dsterba@...e.com>
> Signed-off-by: Anand Jain <anand.jain@...cle.com>
> ---
>  fs/btrfs/disk-io.c | 45 +++++++++++++++++++++++----------------------
>  1 file changed, 23 insertions(+), 22 deletions(-)

Now queued up, thanks.

greg k-h