linux-kernel - Re: [PATCH] staging: r8188eu: remove the HW_VAR_CHECK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 18 Sep 2021 17:20:47 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove the HW_VAR_CHECK_TXBUF "hal
 variable"

On 9/18/21 16:10, Martin Kaiser wrote:
> Setting HW_VAR_CHECK_TXBUF is an empty operation.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/r8188eu/core/rtw_mlme_ext.c | 1 -
>   drivers/staging/r8188eu/hal/usb_halinit.c   | 2 --
>   drivers/staging/r8188eu/include/hal_intf.h  | 1 -
>   3 files changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 26e14e91a42c..38ab1ab18872 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -7785,7 +7785,6 @@ u8 sitesurvey_cmd_hdl(struct adapter *padapter, u8 *pbuf)
>   
>   	if (pmlmeext->sitesurvey_res.state == SCAN_DISABLE) {
>   		/* for first time sitesurvey_cmd */
> -		rtw_hal_set_hwreg(padapter, HW_VAR_CHECK_TXBUF, NULL);
>   
>   		pmlmeext->sitesurvey_res.state = SCAN_START;
>   		pmlmeext->sitesurvey_res.bss_cnt = 0;
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index 5133d533674f..8bb2466d71a2 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -1813,8 +1813,6 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
>   			}
>   		}
>   		break;
> -	case HW_VAR_CHECK_TXBUF:
> -		break;
>   	case HW_VAR_APFM_ON_MAC:
>   		haldata->bMacPwrCtrlOn = *val;
>   		DBG_88E("%s: bMacPwrCtrlOn=%d\n", __func__, haldata->bMacPwrCtrlOn);
> diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h
> index cc8db98cd200..f1ebb6a2395d 100644
> --- a/drivers/staging/r8188eu/include/hal_intf.h
> +++ b/drivers/staging/r8188eu/include/hal_intf.h
> @@ -84,7 +84,6 @@ enum hw_variables {
>   	HW_VAR_EFUSE_BT_USAGE,
>   	HW_VAR_EFUSE_BT_BYTES,
>   	HW_VAR_FIFO_CLEARN_UP,
> -	HW_VAR_CHECK_TXBUF,
>   	HW_VAR_APFM_ON_MAC, /* Auto FSM to Turn On, include clock, isolation,
>   			     * power control for MAC only */
>   	/*  The valid upper nav range for the HW updating, if the true value is
> 

Looks good to me.

Acked-by: Michael Straube <straube.linux@...il.com>

Thanks,
Michael