linux-kernel - Re: [PATCH v2] iio: imu: inv_mpu6050: Mark acpi match table as maybe unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210918185937.1af9c5f5@jic23-huawei>
Date:   Sat, 18 Sep 2021 18:59:37 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Jean-Baptiste Maneyrol <JManeyrol@...ensense.com>
Cc:     Daniel Palmer <daniel@...f.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Mark acpi match table as
 maybe unused

On Mon, 13 Sep 2021 12:19:10 +0000
Jean-Baptiste Maneyrol <JManeyrol@...ensense.com> wrote:

> Hello,
> 
> looks obviously good to me.
> Thanks for your patch.
> 
> Acked-by: Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>

Applied to the togreg branch of iio.git and pushed out as testing for
0-day to see if it can find anything we missed.

Thanks,

Jonathan

> 
> Thanks,
> JB
> 
> From: Daniel Palmer <daniel@...f.com>
> Sent: Monday, September 13, 2021 13:29
> To: jic23@...nel.org <jic23@...nel.org>; lars@...afoo.de <lars@...afoo.de>; Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>; linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>
> Cc: linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; Daniel Palmer <daniel@...f.com>
> Subject: [PATCH v2] iio: imu: inv_mpu6050: Mark acpi match table as maybe unused 
>  
>  CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> When building kernels without ACPI support the table is declared
> but is not used because ACPI_PTR() turns it into a NULL.
> 
> Add the __maybe_unused attribute to stop the compiler whining.
> 
> Signed-off-by: Daniel Palmer <daniel@...f.com>
> ---
> Ignore the first version. I'm an idiot and generated a patch,
> check that it worked, noticed it didn't, fixed it up and then
> forgot to regenerate the patch before sending it.
> 
>  drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> index 95f16951c8f4..3ef17e3f50e2 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> @@ -249,7 +249,7 @@ static const struct of_device_id inv_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, inv_of_match);
>  
> -static const struct acpi_device_id inv_acpi_match[] = {
> +static const struct acpi_device_id __maybe_unused inv_acpi_match[] = {
>          {"INVN6500", INV_MPU6500},
>          { },
>  };