linux-kernel - Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210918022636.GA18195@LAPTOP-UKSR4ENP.internal.baidu.com>
Date:   Sat, 18 Sep 2021 10:26:36 +0800
From:   Cai Huoqing <caihuoqing@...du.com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Dong Aisheng <aisheng.dong@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Stefan Agner <stefan@...er.ch>,
        Linus Walleij <linus.walleij@...aro.org>, open list:
        GPIO SUBSYSTEM <linux-gpio@...r.kernel.org>, ;
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST

On 17 9月 21 08:50:55, Fabio Estevam wrote:
> Hi Cai,
> 
> On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing <caihuoqing@...du.com> wrote:
> >
> > it's helpful for complie test in other platform(e.g.X86)
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> > ---
> >  drivers/pinctrl/freescale/Kconfig | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> > index 21fa21c6547b..defc1f38efc7 100644
> > --- a/drivers/pinctrl/freescale/Kconfig
> > +++ b/drivers/pinctrl/freescale/Kconfig
> > @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP
> >
> >  config PINCTRL_IMX8MM
> >         tristate "IMX8MM pinctrl driver"
> > -       depends on ARCH_MXC
> > +       depends on ARCH_MXC || (COMPILE_TEST && OF)
> >         select PINCTRL_IMX
> 
> I am not sure why you need the && OF, as we have a "select PINCTRL_IMX",
> that already depends on OF.
No, it's just an invalid dependency. PINCTRL_IMX can be selected without OF
opened.
> 
> Also, why was PINCTRL_IMX8DXL not updated?
Ok, I'll update all pinctrl IMX.
> 
> Thanks