linux-kernel - Re: [patch] net: core: Correct the sock::sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163205340825.3254.11987805094738440197.git-patchwork-notify@kernel.org>
Date:   Sun, 19 Sep 2021 12:10:08 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
        mingo@...nel.org, peterz@...radead.org, bigeasy@...utronix.de
Subject: Re: [patch] net: core: Correct the sock::sk_lock.owned lockdep
 annotations

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 18 Sep 2021 14:42:35 +0200 (CEST) you wrote:
> lock_sock_fast() and lock_sock_nested() contain lockdep annotations for the
> sock::sk_lock.owned 'mutex'. sock::sk_lock.owned is not a regular mutex. It
> is just lockdep wise equivalent. In fact it's an open coded trivial mutex
> implementation with some interesting features.
> 
> sock::sk_lock.slock is a regular spinlock protecting the 'mutex'
> representation sock::sk_lock.owned which is a plain boolean. If 'owned' is
> true, then some other task holds the 'mutex', otherwise it is uncontended.
> As this locking construct is obviously endangered by lock ordering issues as
> any other locking primitive it got lockdep annotated via a dedicated
> dependency map sock::sk_lock.dep_map which has to be updated at the lock
> and unlock sites.
> 
> [...]

Here is the summary with links:
  - net: core: Correct the sock::sk_lock.owned lockdep annotations
    https://git.kernel.org/netdev/net/c/2dcb96bacce3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html