linux-kernel - Re: [net-next PATCH 2/3] net: phy: at803x: add resume/suspend function to qca83xx phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YUdo3G1XdxdSv4Fa@lunn.ch>
Date:   Sun, 19 Sep 2021 18:44:12 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH 2/3] net: phy: at803x: add resume/suspend
 function to qca83xx phy

> +static int qca83xx_suspend(struct phy_device *phydev)
> +{
> +	phy_modify(phydev, MII_BMCR, 0, BMCR_PDOWN);
> +
> +	return 0;
> +}
> +
> +static int qca83xx_resume(struct phy_device *phydev)
> +{
> +	return phy_modify(phydev, MII_BMCR, BMCR_PDOWN, 0);
> +}
> +

genphy_suspend() and genphy_resume() do exactly this. Please use the
helpers.

Please also add a patch 0/3 which explains the big picture. It will be
used in the merge commit.

	Andrew