linux-kernel - Re: [PATCH] Input: cyttsp - Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbODGTv1i+KdPPnrwtPL2mFb4zw-acaLoTacjwHB9En_Q@mail.gmail.com>
Date:   Sun, 19 Sep 2021 21:28:40 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Linux Input <linux-input@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: cyttsp - Make use of the helper function dev_err_probe()

On Fri, Sep 17, 2021 at 3:35 AM Cai Huoqing <caihuoqing@...du.com> wrote:
> On 17 9月 21 00:30:32, Linus Walleij wrote:
> > On Thu, Sep 16, 2021 at 5:32 PM Cai Huoqing <caihuoqing@...du.com> wrote:
> >
> > >         if (IS_ERR(ts->reset_gpio)) {
> > >                 error = PTR_ERR(ts->reset_gpio);
> > > -               dev_err(dev, "Failed to request reset gpio, error %d\n", error);
> > > +               dev_err_probe(dev, error, "Failed to request reset gpio\n");
> > >                 return ERR_PTR(error);
> >
> > In this case you're supposed to do
> >
> > return dev_err_probe(dev, error, "Failed to request reset gpio\n");
> the probe function is defined:
> "struct cyttsp *cyttsp_probe("
>
> so it is required to return a PTR:cyttsp *.

What about

return ERR_PTR(dev_err_probe(dev, error, "Failed to request reset gpio\n"));

Yours,
Linus Walleij