linux-kernel - Re: imx8mm board crash in drivers/usb/chipidea/ci_hdrc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Sep 2021 21:33:45 +0200
From:   Heiko Thiery <heiko.thiery@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Peter Chen <peter.chen@....com>, Jun Li <jun.li@....com>,
        Yu Kuai <yukuai3@...wei.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Mark Brown <broonie@...nel.org>,
        USB list <linux-usb@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Frieder Schrempf <frieder.schrempf@...tron.de>
Subject: Re: imx8mm board crash in drivers/usb/chipidea/ci_hdrc_imx.c

Hi Fabio,

Am So., 19. Sept. 2021 um 15:08 Uhr schrieb Fabio Estevam <festevam@...il.com>:
>
> Hi Heiko,
>
> On Sun, Sep 19, 2021 at 7:10 AM Heiko Thiery <heiko.thiery@...il.com> wrote:
>
> > Meanwhile I figured out that in ci_hdrc_imx_probe() the "fsl,usbphy"
> > node is not found [1]. But I do not understand why.
> >
> > The following failure leads to the return code of -19 (ENODEV) and
> > sets the pyh to NULL:
> > "failed to get fsl,usbphy phandle in /soc@...us@...00000/usb@...40000 node"
>
> Since commit:
> commit 78e80c4b4238c1f5642b975859664fced4f9c69e
> Author: Marek Vasut <marex@...x.de>
> Date:   Wed Jul 21 18:39:55 2021 +0200
>
>     arm64: dts: imx8m: Replace deprecated fsl,usbphy DT props with phys
>
>     The fsl,usbphy DT property is deprecated, replace it with phys DT
>     property and specify #phy-cells. No functional change.
>
>     Signed-off-by: Marek Vasut <marex@...x.de>
>     Cc: Fabio Estevam <festevam@...il.com>
>     Cc: NXP Linux Team <linux-imx@....com>
>     Cc: Shawn Guo <shawnguo@...nel.org>
>     To: linux-arm-kernel@...ts.infradead.org
>     Signed-off-by: Shawn Guo <shawnguo@...nel.org>
>
> Don't we need to search for 'phys' too?
>
> Does this patch help?
> https://pastebin.com/raw/yZKz1huL

I can confirm that on the next-20210915 (that includes commit
78e80c4b4238c1f5642b975859664fced4f9c69e) your provided patch solves
the problem.

But is it explainable that in the version before the commit
78e80c4b4238c1f5642b975859664fced4f9c69e the problem occurs in the
form I reported?

-- 
Heiko