linux-kernel - Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpW8hGBinQKTqKidYfn5sJjAYMUMHyr4U-=dn_CfWVLtMQ@mail.gmail.com>
Date:   Sun, 19 Sep 2021 16:25:00 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Yajun Deng <yajun.deng@...ux.dev>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain()

On Sat, Sep 18, 2021 at 7:28 AM Yajun Deng <yajun.deng@...ux.dev> wrote:
>
> The key_domain member in struct net only exists if we define CONFIG_KEYS.
> So we should add the define when we used key_domain.

But key_remove_domain() is just a nop if !CONFIG_KEYS:

#else /* CONFIG_KEYS */
...
#define key_remove_domain(d)            do { } while(0)

So what exactly are you fixing?

Thanks.