linux-kernel - [tglx-devel:hrtimer 5/12] net/can/bcm.c:628:60: error: expected ')' before ';' token

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Mon, 20 Sep 2021 07:33:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [tglx-devel:hrtimer 5/12] net/can/bcm.c:628:60: error: expected ')'
 before ';' token

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git hrtimer
head:   16c372aeaca31d5d9d998466e75e845a2926685f
commit: df0b0ce19903f84991732242cb7c058dd229d587 [5/12] can: bcm: Use hrtimer_forward_now()
config: nds32-randconfig-r026-20210919 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/commit/?id=df0b0ce19903f84991732242cb7c058dd229d587
        git remote add tglx-devel https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git
        git fetch --no-tags tglx-devel hrtimer
        git checkout df0b0ce19903f84991732242cb7c058dd229d587
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash net/can/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   net/can/bcm.c: In function 'bcm_rx_thr_handler':
   net/can/bcm.c:628:45: warning: left-hand operand of comma expression has no effect [-Wunused-value]
     628 |                 hrtimer_forward_now((hrtimer, op->kt_ival2);
         |                                             ^
>> net/can/bcm.c:628:60: error: expected ')' before ';' token
     628 |                 hrtimer_forward_now((hrtimer, op->kt_ival2);
         |                                    ~                       ^
         |                                                            )
>> net/can/bcm.c:628:45: warning: passing argument 1 of 'hrtimer_forward_now' makes pointer from integer without a cast [-Wint-conversion]
     628 |                 hrtimer_forward_now((hrtimer, op->kt_ival2);
         |                                     ~~~~~~~~^~~~~~~~~~~~~~~
         |                                             |
         |                                             ktime_t {aka long long int}
   In file included from include/linux/sched.h:19,
                    from include/linux/sched/task_stack.h:9,
                    from arch/nds32/include/asm/fpu.h:9,
                    from arch/nds32/include/asm/elf.h:12,
                    from include/linux/elf.h:6,
                    from include/linux/module.h:19,
                    from net/can/bcm.c:43:
   include/linux/hrtimer.h:503:55: note: expected 'struct hrtimer *' but argument is of type 'ktime_t' {aka 'long long int'}
     503 | static inline u64 hrtimer_forward_now(struct hrtimer *timer,
         |                                       ~~~~~~~~~~~~~~~~^~~~~
>> net/can/bcm.c:628:17: error: too few arguments to function 'hrtimer_forward_now'
     628 |                 hrtimer_forward_now((hrtimer, op->kt_ival2);
         |                 ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/sched.h:19,
                    from include/linux/sched/task_stack.h:9,
                    from arch/nds32/include/asm/fpu.h:9,
                    from arch/nds32/include/asm/elf.h:12,
                    from include/linux/elf.h:6,
                    from include/linux/module.h:19,
                    from net/can/bcm.c:43:
   include/linux/hrtimer.h:503:19: note: declared here
     503 | static inline u64 hrtimer_forward_now(struct hrtimer *timer,
         |                   ^~~~~~~~~~~~~~~~~~~
>> net/can/bcm.c:629:40: error: expected ';' before '}' token
     629 |                 return HRTIMER_RESTART;
         |                                        ^
         |                                        ;
     630 |         } else {
         |         ~                               
   net/can/bcm.c:635:1: error: control reaches end of non-void function [-Werror=return-type]
     635 | }
         | ^
   cc1: some warnings being treated as errors


vim +628 net/can/bcm.c

   618	
   619	/*
   620	 * bcm_rx_thr_handler - the time for blocked content updates is over now:
   621	 *                      Check for throttled data and send it to the userspace
   622	 */
   623	static enum hrtimer_restart bcm_rx_thr_handler(struct hrtimer *hrtimer)
   624	{
   625		struct bcm_op *op = container_of(hrtimer, struct bcm_op, thrtimer);
   626	
   627		if (bcm_rx_thr_flush(op)) {
 > 628			hrtimer_forward_now((hrtimer, op->kt_ival2);
 > 629			return HRTIMER_RESTART;
   630		} else {
   631			/* rearm throttle handling */
   632			op->kt_lastmsg = 0;
   633			return HRTIMER_NORESTART;
   634		}
   635	}
   636	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33606 bytes)