linux-kernel - Re: [PATCH v4 5/9] ARM: imx_v6_v7_defconfig: build imx sdma driver as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12e1d4b64f3f7f705439cdf7b81f4ead75909948.camel@pengutronix.de>
Date:   Mon, 20 Sep 2021 18:50:23 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Marek Vasut <marex@...x.de>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Cc:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "andreas@...nade.info" <andreas@...nade.info>,
        "linux-imx@....com" <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "pzimmermann@...electronics.com" <pzimmermann@...electronics.com>,
        "festevam@...il.com" <festevam@...il.com>
Subject: Re: [PATCH v4 5/9] ARM: imx_v6_v7_defconfig: build imx sdma driver
 as module

Am Montag, dem 20.09.2021 um 18:14 +0200 schrieb Marek Vasut:
> On 9/20/21 5:55 PM, Marcel Ziswiler wrote:
> > On Mon, 2021-09-20 at 16:52 +0200, Marek Vasut wrote:
> > > On 9/20/21 4:49 PM, Marcel Ziswiler wrote:
> > > > From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > > > 
> > > > Build CONFIG_IMX_SDMA as a module to avoid the following boot issue:
> > > > 
> > > > [    5.214751] imx-sdma 20ec000.sdma: Direct firmware load for
> > > >    imx/sdma/sdma-imx6q.bin failed with error -2
> > > > [    5.215762] imx-sdma 20ec000.sdma: Falling back to sysfs fallback
> > > >    for: imx/sdma/sdma-imx6q.bin
> > > 
> > > Isn't there some ROM-side SDMA firmware baked into the MX6 which is used
> > > as a fallback if loading newer one from filesystem fails ? I suspect the
> > > default ROM firmware might be buggy.
> > 
> > I'm not so sure about this. At least it seems to fail if no external firmware can be loaded.
> 
> See e.g. SDMA chapter in MX6SDLRM or similar, it does talk about 4k boot 
> ROM, which contains scripts and utilities later referenced by scripts in 
> RAM. It might be worth looking into that a bit further, but that seems 
> like a separate topic from this patch.
> 
Yep, most of the systems we ship do work with the ROM firmware, which
should be picked when firmware loading fails.

The RAM firmware is useful in some cases like multichannel SAI or now
to work around the SPI DMA issue on i.MX6.

Regards,
Lucas