linux-kernel - Re: [PATCH v2] misc: genwqe: Remove usage of the deprecated "pci-dma-compat.h" API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2CBvw_GP372R+p8f4_pa82sMuQ5iHk4Nb2dJCzm_Fivw@mail.gmail.com>
Date:   Mon, 20 Sep 2021 09:32:40 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Arnd Bergmann <arnd@...db.de>, gregkh <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] misc: genwqe: Remove usage of the deprecated
 "pci-dma-compat.h" API

On Sat, Sep 18, 2021 at 3:10 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:

>
> considering that the 3 patches that you have just review are done, the
> diffsat of what is remaining is:
>
>    32 files changed, 309 insertions(+), 272 deletions(-)
>
>
> All corresponding patches have already been proposed.
> Most of the patches are not that old (i.e. < 1 month)
>
> They all *look* trivial to me, *EXCEPT* the ones for message/fusion.

Agreed, nice work getting this far!

> I've tried to split the latter in small series in the hope of easing review.
> Moreover the drivers/message/fusion directory seems to be inactive since
> a few months. I don't know if it is just related to the summer or if
> this code is for some reason stalled.
> This is funny, because the very start for me of this clean-up effort was
> related to an issue in memory allocation in message/fusion fixed by
> Christoph Hellwig :)

It is fairly old code that predates the git history, with the last two
device IDs
added in 2007 and 2011, so I would not expect it to be very active.
It's also part of the SCSI subsystem, so I think you just need to resend
it to the scsi maintainers (cc the listed driver maintainers) asking for it to
get merged unless the maintainers have a specific objection.

Once the fusion-mpt stuff is merged, I'd call it endgame and suggest
you send the remaining 12 patches and the removal of the header file
as a series to Andrew Morton, Cc all the driver maintainers to give them
a final notice: each maintainer can then either apply their trivial patch
for linux-next, or Andrew applies it, with the header removal coming last.

         Arnd