linux-kernel - [PATCH 5.14 049/168] drm/i915/dp: return proper DPRX link training result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210920163923.250441951@linuxfoundation.org>
Date:   Mon, 20 Sep 2021 18:43:07 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org,
        Ville Syrjala <ville.syrjala@...ux.intel.com>,
        Imre Deak <imre.deak@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Cooper Chiou <cooper.chiou@...el.com>,
        William Tseng <william.tseng@...el.com>,
        Lee Shawn C <shawn.c.lee@...el.com>,
        Jani Nikula <jani.nikula@...el.com>
Subject: [PATCH 5.14 049/168] drm/i915/dp: return proper DPRX link training result

From: Lee Shawn C <shawn.c.lee@...el.com>

commit 9af4bf2171c1a9e3f2ebb21140c0e34e60b2a22a upstream.

After DPRX link training, intel_dp_link_train_phy() did not
return the training result properly. If link training failed,
i915 driver would not run into link train fallback function.
And no hotplug uevent would be received by user space application.

Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode link training")
Cc: Ville Syrjala <ville.syrjala@...ux.intel.com>
Cc: Imre Deak <imre.deak@...el.com>
Cc: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Cooper Chiou <cooper.chiou@...el.com>
Cc: William Tseng <william.tseng@...el.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@...el.com>
Reviewed-by: Imre Deak <imre.deak@...el.com>
Signed-off-by: Imre Deak <imre.deak@...el.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210706152541.25021-1-shawn.c.lee@intel.com
(cherry picked from commit dab1b47e57e053b2a02c22ead8e7449f79961335)
Signed-off-by: Jani Nikula <jani.nikula@...el.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 drivers/gpu/drm/i915/display/intel_dp_link_training.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -848,7 +848,7 @@ intel_dp_link_train_all_phys(struct inte
 	}
 
 	if (ret)
-		intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
+		ret = intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
 
 	if (intel_dp->set_idle_link_train)
 		intel_dp->set_idle_link_train(intel_dp, crtc_state);