linux-kernel - Re: [PATCH 7/8] vhost: use kernel_copy_process to check RLIMITs and inherit cgroups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 21 Sep 2021 04:47:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mike Christie <michael.christie@...cle.com>, stefanha@...hat.com,
        jasowang@...hat.com, mst@...hat.com, sgarzare@...hat.com,
        virtualization@...ts.linux-foundation.org,
        christian.brauner@...ntu.com, axboe@...nel.dk,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org,
        Mike Christie <michael.christie@...cle.com>
Subject: Re: [PATCH 7/8] vhost: use kernel_copy_process to check RLIMITs and
 inherit cgroups

Hi Mike,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mst-vhost/linux-next]
[also build test ERROR on linus/master v5.15-rc2 next-20210920]
[cannot apply to tip/sched/core tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mike-Christie/Use-copy_process-create_io_thread-in-vhost-layer/20210917-052427
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/57f4cf5028dd552f4895a6a83a8607412ceb8b6c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mike-Christie/Use-copy_process-create_io_thread-in-vhost-layer/20210917-052427
        git checkout 57f4cf5028dd552f4895a6a83a8607412ceb8b6c
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/sched.h:10,
                    from include/linux/eventfd.h:17,
                    from drivers/vhost/vhost.c:13:
   drivers/vhost/vhost.c: In function 'vhost_worker_create':
>> include/uapi/linux/sched.h:12:18: error: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '4294967808' to '512' [-Werror=overflow]
      12 | #define CLONE_FS 0x00000200 /* set if fs info shared between processes */
         |                  ^
   drivers/vhost/vhost.c:626:8: note: in expansion of macro 'CLONE_FS'
     626 |        CLONE_FS|CLONE_CLEAR_SIGHAND, 0, 1);
         |        ^~~~~~~~
   At top level:
   drivers/vhost/vhost.c:532:12: error: 'vhost_attach_cgroups' defined but not used [-Werror=unused-function]
     532 | static int vhost_attach_cgroups(struct vhost_dev *dev)
         |            ^~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +12 include/uapi/linux/sched.h

7f192e3cd316ba Christian Brauner 2019-05-25   6  
607ca46e97a1b6 David Howells     2012-10-13   7  /*
607ca46e97a1b6 David Howells     2012-10-13   8   * cloning flags:
607ca46e97a1b6 David Howells     2012-10-13   9   */
607ca46e97a1b6 David Howells     2012-10-13  10  #define CSIGNAL		0x000000ff	/* signal mask to be sent at exit */
607ca46e97a1b6 David Howells     2012-10-13  11  #define CLONE_VM	0x00000100	/* set if VM shared between processes */
607ca46e97a1b6 David Howells     2012-10-13 @12  #define CLONE_FS	0x00000200	/* set if fs info shared between processes */
607ca46e97a1b6 David Howells     2012-10-13  13  #define CLONE_FILES	0x00000400	/* set if open files shared between processes */
607ca46e97a1b6 David Howells     2012-10-13  14  #define CLONE_SIGHAND	0x00000800	/* set if signal handlers and blocked signals shared */
b3e5838252665e Christian Brauner 2019-03-27  15  #define CLONE_PIDFD	0x00001000	/* set if a pidfd should be placed in parent */
607ca46e97a1b6 David Howells     2012-10-13  16  #define CLONE_PTRACE	0x00002000	/* set if we want to let tracing continue on the child too */
607ca46e97a1b6 David Howells     2012-10-13  17  #define CLONE_VFORK	0x00004000	/* set if the parent wants the child to wake it up on mm_release */
607ca46e97a1b6 David Howells     2012-10-13  18  #define CLONE_PARENT	0x00008000	/* set if we want to have the same parent as the cloner */
607ca46e97a1b6 David Howells     2012-10-13  19  #define CLONE_THREAD	0x00010000	/* Same thread group? */
fcd964dda5ece2 Chen Hanxiao      2014-10-07  20  #define CLONE_NEWNS	0x00020000	/* New mount namespace group */
607ca46e97a1b6 David Howells     2012-10-13  21  #define CLONE_SYSVSEM	0x00040000	/* share system V SEM_UNDO semantics */
607ca46e97a1b6 David Howells     2012-10-13  22  #define CLONE_SETTLS	0x00080000	/* create a new TLS for the child */
607ca46e97a1b6 David Howells     2012-10-13  23  #define CLONE_PARENT_SETTID	0x00100000	/* set the TID in the parent */
607ca46e97a1b6 David Howells     2012-10-13  24  #define CLONE_CHILD_CLEARTID	0x00200000	/* clear the TID in the child */
607ca46e97a1b6 David Howells     2012-10-13  25  #define CLONE_DETACHED		0x00400000	/* Unused, ignored */
607ca46e97a1b6 David Howells     2012-10-13  26  #define CLONE_UNTRACED		0x00800000	/* set if the tracing process can't force CLONE_PTRACE on this clone */
607ca46e97a1b6 David Howells     2012-10-13  27  #define CLONE_CHILD_SETTID	0x01000000	/* set the TID in the child */
5e2bec7c2248ae Aditya Kali       2016-01-29  28  #define CLONE_NEWCGROUP		0x02000000	/* New cgroup namespace */
f622b429dadf83 Chen Hanxiao      2014-11-04  29  #define CLONE_NEWUTS		0x04000000	/* New utsname namespace */
f622b429dadf83 Chen Hanxiao      2014-11-04  30  #define CLONE_NEWIPC		0x08000000	/* New ipc namespace */
607ca46e97a1b6 David Howells     2012-10-13  31  #define CLONE_NEWUSER		0x10000000	/* New user namespace */
607ca46e97a1b6 David Howells     2012-10-13  32  #define CLONE_NEWPID		0x20000000	/* New pid namespace */
607ca46e97a1b6 David Howells     2012-10-13  33  #define CLONE_NEWNET		0x40000000	/* New network namespace */
607ca46e97a1b6 David Howells     2012-10-13  34  #define CLONE_IO		0x80000000	/* Clone io context */
607ca46e97a1b6 David Howells     2012-10-13  35  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (66061 bytes)