lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 20 Sep 2021 14:13:54 -0700
From:   Wesley Cheng <wcheng@...eaurora.org>
To:     Amit Pundir <amit.pundir@...aro.org>
Cc:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jack Pham <jackp@...eaurora.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        John Stultz <john.stultz@...aro.org>,
        linux-usb@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dt <devicetree@...r.kernel.org>
Subject: Re: dwc3-qcom: tx-fifo-resize regression on Poco F1 (sdm845) with
 v5.15-rc1

Hi Amit,

On 9/20/2021 1:45 PM, Amit Pundir wrote:
> Hi Wesley, All,
> 
> I see a reboot loop on Xiaomi Pocophone F1 (sdm845) with TX FIFO
> resize patches which landed in v5.15-rc1. Upstream commit cefdd52fa045
> "usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default" to
> be specific, which switched on this feature by default.
> 
> At times the phone crashes into the fastboot mode after the reboot
> loop, but mostly end up booting to UI after a while. This is what it
> looks like https://people.linaro.org/~amit.pundir/beryllium-userdebug/PXL_20210920_162749483.mp4.
> 

I believe Android will attempt a number of bootup sequences and if it
fails, it falls back to fastboot mode.  Are there any available logs you
might be able to collect to see where the issue is?

> PocoF1 does support TX fifo resizing as I can see that in the
> downstream dts. So maybe it is the tx-fifo-max-num which need to be
> adjusted for the device? I couldn't find the tx-fifo-max-num
> equivalent in the downstream tree though
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/tree/dipper-q-oss/
> 

I assume that you've already confirmed reverting that change resolves
the constant reboots?

> Curious if you had any ideas what might be going wrong? For now I'll
> keep digging around tx-fifo-max-num, but I figured I'd ask just in
> case it's obvious to you.
> 

The tx-fifo-max-num parameter should still be set to 6 for SDM845, which
would be the same for more recent targets as well.

Thanks
Wesley Cheng

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Powered by blists - more mailing lists