linux-kernel - Re: [PATCH 3/3] firmware: arm_scmi: Add proper barriers to scmi virtio device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210920110934.aloikpcc6uawouou@bogus>
Date:   Mon, 20 Sep 2021 12:09:34 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Cristian Marussi <cristian.marussi@....com>,
        "Michael S. Tsirkin" <mst@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        virtualization@...ts.linux-foundation.org,
        virtio-dev@...ts.oasis-open.org, james.quinlan@...adcom.com,
        Jonathan.Cameron@...wei.com, f.fainelli@...il.com,
        etienne.carriere@...aro.org, vincent.guittot@...aro.org,
        souvik.chakravarty@....com, igor.skalkin@...nsynergy.com,
        peter.hilber@...nsynergy.com, alex.bennee@...aro.org,
        jean-philippe@...aro.org, mikhail.golubev@...nsynergy.com,
        anton.yakovlev@...nsynergy.com, Vasyl.Vavrychuk@...nsynergy.com,
        Tryshnivskyy@...nsynergy.com, "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 3/3] firmware: arm_scmi: Add proper barriers to scmi
 virtio device

Hi Michael,

On Thu, Sep 16, 2021 at 11:33:36AM +0100, Cristian Marussi wrote:
> Only one single SCMI Virtio device is currently supported by this driver
> and it is referenced using a static global variable which is initialized
> once for all during probing and nullified at virtio device removal.
> 
> Add proper SMP barriers to protect accesses to such device reference to
> ensure that the initialzation state of such device is correctly observed by
> all PEs at any time.
> 
> Return -EBUSY, instead of -EINVAL, and a descriptive error message if more
> than one SCMI Virtio device is ever found and probed.
> 

I was thinking of applying this patch and probably 2/3 as fix for v5.15.
Let me know if you have any objections.

--
Regards,
Sudeep