linux-kernel - Re: [tip: x86/urgent] x86/setup: Call early_reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Sep 2021 13:25:25 +0200
From:   Mike Galbraith <efault@....de>
To:     Mike Rapoport <rppt@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
        marmarek@...isiblethingslab.com, Juergen Gross <jgross@...e.com>,
        Borislav Petkov <bp@...e.de>, stable@...r.kernel.org,
        x86@...nel.org
Subject: Re: [tip: x86/urgent] x86/setup: Call early_reserve_memory() earlier

On Mon, 2021-09-20 at 12:26 +0300, Mike Rapoport wrote:
>
> Can't say anything caught my eye, except the early microcode update.
> Just to rule that out, can you try booting without the early microcode
> update?

Nogo.

> And, to check Juergen's suggestion about failure in
> memblock_x86_reserve_range_setup_data(), can you try this patch on top of
> the failing tip:

Yup, patchlet detoxified it for both boxen.

> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 25425edc81a4..78162d9e90cf 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -716,8 +716,6 @@ static void __init early_reserve_memory(void)
>         if (efi_enabled(EFI_BOOT))
>                 efi_memblock_x86_reserve_range();
>  
> -       memblock_x86_reserve_range_setup_data();
> -
>         reserve_ibft_region();
>         reserve_bios_regions();
>         trim_snb_memory();
> @@ -888,6 +886,8 @@ void __init setup_arch(char **cmdline_p)
>          */
>         x86_configure_nx();
>  
> +       memblock_x86_reserve_range_setup_data();
> +
>         parse_early_param();
>  
>  #ifdef CONFIG_MEMORY_HOTPLUG
>