linux-kernel - Re: [PATCH v8 09/19] staging: r8188eu: remove unnecessary braces in usbctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Sep 2021 13:49:40 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        David Laight <david.Laight@...lab.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Martin Kaiser <martin@...ser.cx>
Subject: Re: [PATCH v8 09/19] staging: r8188eu: remove unnecessary braces in
 usbctrl_vendorreq()

On Mon, Sep 20, 2021 at 01:53:46AM +0200, Fabio M. De Francesco wrote:
> Remove unnecessary braces in usbctrl_vendorreq().
> 
> Co-developed-by: Pavel Skripkin <paskripkin@...il.com>
> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> ---
>  drivers/staging/r8188eu/hal/usb_ops_linux.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> index 3ca2959f4bcd..a270cb4249b5 100644
> --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> @@ -72,9 +72,8 @@ static int usbctrl_vendorreq(struct intf_hdl *intfhdl, u16 value, void *data, u1
>  			} else {
>  				/* status != len && status >= 0 */
>  				if (status > 0) {
> -					if (requesttype == REALTEK_USB_VENQT_READ) {
> +					if (requesttype == REALTEK_USB_VENQT_READ)
>  						memcpy(data, io_buf,  len);
> -					}

This should have gone in the previous commit.