linux-kernel - Re: [PATCH v8 12/19] staging: r8188eu: change the type of a variable in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUh1mCpdcncATAkC@kroah.com>
Date:   Mon, 20 Sep 2021 13:50:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        David Laight <david.Laight@...lab.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Martin Kaiser <martin@...ser.cx>
Subject: Re: [PATCH v8 12/19] staging: r8188eu: change the type of a variable
 in rtw_write16()

On Mon, Sep 20, 2021 at 01:53:49AM +0200, Fabio M. De Francesco wrote:
> Change the type of "data" from __le32 to __le16.

You are saying _what_ you are doing here, but it is not obvious at all
_why_ you need to do this.

Please explain the why here when you redo this series.

thanks,

greg k-h