linux-kernel - Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUiOixF5/op1hXLf@atomide.com>
Date:   Mon, 20 Sep 2021 16:37:15 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Gowtham Tammana <g-tammana@...com>,
        Jyri Sarha <jsarha@...com>
Subject: Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module

Hi,

* Neil Armstrong <narmstrong@...libre.com> [210920 12:53]:
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -965,6 +965,26 @@ hdmi: encoder@0 {
>  			};
>  		};
>  
> +		target-module@...00000 {
> +			compatible = "ti,sysc-omap4", "ti,sysc";
> +			reg = <0x59000020 0x4>;
> +			reg-names = "rev";
> +			clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
> +			clock-names = "fck";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0x0 0x59000000 0x1000>;
> +
> +			bb2d: gpu@0 {
> +				compatible = "vivante,gc";
> +				reg = <0x0 0x0700>;
> +				interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
> +				clock-names = "core";
> +				status = "disabled";
> +			};
> +		};
> +
>  		aes1_target: target-module@...00000 {
>  			compatible = "ti,sysc-omap2", "ti,sysc";
>  			reg = <0x4b500080 0x4>,

How about just use the default for the bb2d node with is "okay"?
That way there's no need set status = "okay" for each board file.

If there is no driver loaded, we idle the target-module anyways.

Regards,

Tony