linux-kernel - [bvanassche:scsi-remove-done-callback 85/88] drivers/staging/unisys/visorhba/visorhba_main.c:330:3: error: implicit declaration of function 'scsiscsi_done'; did you mean 'scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 20 Sep 2021 23:26:28 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bart Van Assche <bvanassche@....org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [bvanassche:scsi-remove-done-callback 85/88]
 drivers/staging/unisys/visorhba/visorhba_main.c:330:3: error: implicit
 declaration of function 'scsiscsi_done'; did you mean 'scsi_done'?

tree:   https://github.com/bvanassche/linux scsi-remove-done-callback
head:   2faae7ba7945dc7a193b50531239b7a4ff7e1fb5
commit: 1ba5f0a53a24e21b9f57521305680e587181e65c [85/88] staging: unisys: visorhba: Call scsi_done() directly
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/bvanassche/linux/commit/1ba5f0a53a24e21b9f57521305680e587181e65c
        git remote add bvanassche https://github.com/bvanassche/linux
        git fetch --no-tags bvanassche scsi-remove-done-callback
        git checkout 1ba5f0a53a24e21b9f57521305680e587181e65c
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_abort_handler':
>> drivers/staging/unisys/visorhba/visorhba_main.c:330:3: error: implicit declaration of function 'scsiscsi_done'; did you mean 'scsi_done'? [-Werror=implicit-function-declaration]
     330 |   scsiscsi_done(scsicmd);
         |   ^~~~~~~~~~~~~
         |   scsi_done
   cc1: all warnings being treated as errors


vim +330 drivers/staging/unisys/visorhba/visorhba_main.c

   307	
   308	/*
   309	 * visorhba_abort_handler - Send TASK_MGMT_ABORT_TASK
   310	 * @scsicmd: The scsicmd that needs aborted
   311	 *
   312	 * Return: SUCCESS if inserted, FAILED otherwise
   313	 */
   314	static int visorhba_abort_handler(struct scsi_cmnd *scsicmd)
   315	{
   316		/* issue TASK_MGMT_ABORT_TASK */
   317		struct scsi_device *scsidev;
   318		struct visordisk_info *vdisk;
   319		int rtn;
   320	
   321		scsidev = scsicmd->device;
   322		vdisk = scsidev->hostdata;
   323		if (atomic_read(&vdisk->error_count) < VISORHBA_ERROR_COUNT)
   324			atomic_inc(&vdisk->error_count);
   325		else
   326			atomic_set(&vdisk->ios_threshold, IOS_ERROR_THRESHOLD);
   327		rtn = forward_taskmgmt_command(TASK_MGMT_ABORT_TASK, scsidev);
   328		if (rtn == SUCCESS) {
   329			scsicmd->result = DID_ABORT << 16;
 > 330			scsiscsi_done(scsicmd);
   331		}
   332		return rtn;
   333	}
   334	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (66503 bytes)