linux-kernel - Re: [PATCH] pinctrl-intel: Fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Sep 2021 19:00:43 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     zboszor@...hu
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andy@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Zoltán Böszörményi <zboszor@...il.com>
Subject: Re: [PATCH] pinctrl-intel: Fix NULL pointer dereference

On Mon, Sep 20, 2021 at 4:00 PM <zboszor@...hu> wrote:
> On an Elkhart Lake based POS hardware prototype, I got this Oops:

Thank you for the report, my comments below.

> [    1.587455] BUG: kernel NULL pointer dereference, address: 0000000000000000

First of all, do not spoil the commit message with unneeded lines of
the traceback. Only ~4-5 is usually more than enough.

> It's probably a firmware bug, so be overly protective:

Patch is simply wrong. While Oops will be gone, the driver won't work correctly.
Yes, it's either a firmware bug or the driver is outdated (depends
from which side you look at this issue).

I have heard that new firmware is on its way to the customers, but I
have no more information right now.

-- 
With Best Regards,
Andy Shevchenko