linux-kernel - Re: [PATCH 00/11] fs/ntfs3: Refactor fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Sep 2021 19:07:44 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Kari Argillander <kari.argillander@...il.com>,
        <ntfs3@...ts.linux.dev>
CC:     <linux-kernel@...r.kernel.org>,
        Christian Brauner <christian.brauner@...ntu.com>
Subject: Re: [PATCH 00/11] fs/ntfs3: Refactor fill_super



On 09.09.2021 21:09, Kari Argillander wrote:
> Two first ones are only ones that fix something. Everything else
> just take off dead code or make it little bit cleaner. They should
> be pretty trivial.
> 
> As promise to Christian, 10/11 makes one section cleaner as he
> wanted [1].
> 
> [1]: lore.kernel.org/ntfs3/20210824113217.ncuwc3zs452mdgec@...tgenstein
> 
> Kari Argillander (11):
>   fs/ntfs3: Fix wrong error message $Logfile -> $UpCase
>   fs/ntfs3: Change EINVAL to ENOMEM when d_make_root fails
>   fs/ntfs3: Remove impossible fault condition in fill_super
>   fs/ntfs3: Return straight without goto in fill_super
>   fs/ntfs3: Remove unnecessary variable loading in fill_super
>   fs/ntfs3: Use sb instead of sbi->sb in fill_super
>   fs/ntfs3: Remove tmp var is_ro in ntfs_fill_super
>   fs/ntfs3: Remove tmp pointer bd_inode in fill_super
>   fs/ntfs3: Remove tmp pointer upcase in fill_super
>   fs/ntfs3: Initialize pointer before use place in fill_super
>   fs/ntfs3: Initiliaze sb blocksize only in one place + refactor
> 
>  fs/ntfs3/super.c | 121 +++++++++++++----------------------------------
>  1 file changed, 33 insertions(+), 88 deletions(-)
> 
> 
> base-commit: 15b2ae776044ac52cddda8a3e6c9fecd15226b8c
> 

Thanks for work - applied!