linux-kernel - Re: [PATCH] crypto: ecc: fix CRYPTO_DEFAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Sep 2021 12:25:18 -0400
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Vitaly Chikunov <vt@...linux.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Ard Biesheuvel <ardb@...nel.org>,
        Eric Biggers <ebiggers@...gle.com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ecc: fix CRYPTO_DEFAULT_RNG dependency


On 9/20/21 6:05 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The ecc.c file started out as part of the ECDH algorithm but got
> moved out into a standalone module later. It does not build without
> CRYPTO_DEFAULT_RNG, so now that other modules are using it as well we
> can run into this link error:
>
> aarch64-linux-ld: ecc.c:(.text+0xfc8): undefined reference to `crypto_default_rng'
> aarch64-linux-ld: ecc.c:(.text+0xff4): undefined reference to `crypto_put_default_rng'
>
> Move the 'select CRYPTO_DEFAULT_RNG' statement into the correct symbol.
>
> Fixes: 0d7a78643f69 ("crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm")
> Fixes: 4e6602916bc6 ("crypto: ecdsa - Add support for ECDSA signature verification")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>


> ---
>   crypto/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 536df4b6b825..285f82647d2b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -233,12 +233,12 @@ config CRYPTO_DH
>   
>   config CRYPTO_ECC
>   	tristate
> +	select CRYPTO_RNG_DEFAULT
>   
>   config CRYPTO_ECDH
>   	tristate "ECDH algorithm"
>   	select CRYPTO_ECC
>   	select CRYPTO_KPP
> -	select CRYPTO_RNG_DEFAULT
>   	help
>   	  Generic implementation of the ECDH algorithm
>