linux-kernel - [net-next PATCH 0/1] Sgmii fix for qca8k qca8327 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210920164745.30162-1-ansuelsmth@gmail.com>
Date:   Mon, 20 Sep 2021 18:47:44 +0200
From:   Ansuel Smith <ansuelsmth@...il.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Ansuel Smith <ansuelsmth@...il.com>
Subject: [net-next PATCH 0/1] Sgmii fix for qca8k qca8327 switch

Some background for this. As stated in other patch, we are testing
qca8327 switch in various device. We tought this was a specific
configuration of the switch and needed special binding to disable pll on
sgmii port. With a better analysis of the original qca driver it was
discovered that pll was only enabled on switch revision 1.

By testing the same configuration with a qca8337 switch that have a
revision 2, using the secondary cpu port (set as sgmii) as primary
(removed the first cpu port from dts and updated the driver to use the
secondary cpu port port6 for everything) confirmed that pll enabled is
not actually needed and all works correctly.
Different case for another router with a qca8327 switch that with the
extra option enabled doesn't work at all and no traffic can be detected.

Also in the original driver the signal detection (SD bit 4) is never
enabled. Having that enabled doesn't seems to give any problem so i
won't disable that, but i'm just pointing this out to think about it.

Don't know if that should be disabled or not but the pll changes is
absolutely needed as in some case it cause the malfunction of the entire
connection.

Ansuel Smith (1):
  drivers: net: dsa: qca8k: fix sgmii with some specific switch revision

 drivers/net/dsa/qca8k.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

-- 
2.32.0