linux-kernel - Re: [PATCH v3] mm: fs: invalidate bh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUkeOB3GfK6KO8KG@google.com>
Date:   Mon, 20 Sep 2021 16:50:16 -0700
From:   Minchan Kim <minchan@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        zhengjun.xing@...el.com
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Laura Abbott <labbott@...nel.org>,
        Oliver Sang <oliver.sang@...el.com>,
        David Hildenbrand <david@...hat.com>,
        John Dias <joaodias@...gle.com>,
        Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...e.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>, lkp@...ts.01.org,
        kernel test robot <lkp@...el.com>,
        "Huang, Ying" <ying.huang@...el.com>,
        Feng Tang <feng.tang@...el.com>, zhengjun.xing@...el.com,
        Chris Goldsworthy <cgoldswo@...eaurora.org>
Subject: Re: [PATCH v3] mm: fs: invalidate bh_lrus for only cold path

On Mon, Sep 20, 2021 at 04:29:52PM -0700, Linus Torvalds wrote:
> On Tue, Sep 7, 2021 at 2:24 PM Minchan Kim <minchan@...nel.org> wrote:
> >
> > kernel test robot reported the regression of fio.write_iops[1]
> > with [2].
> >
> > Since lru_add_drain is called frequently, invalidate bh_lrus
> > there could increase bh_lrus cache miss ratio, which needs
> > more IO in the end.
> >
> > This patch moves the bh_lrus invalidation from the hot path(
> > e.g., zap_page_range, pagevec_release) to cold path(i.e.,
> > lru_add_drain_all, lru_cache_disable).
> 
> Was this confirmed to fix the regression?
> 
> I only see the "tested with 5.14" that the regression was still there
> 
>    https://lore.kernel.org/lkml/034fc860-d0d0-0c61-09d2-3c41c4f020c6@intel.com/
> 
> I don't see a confirmation that this patch fixed it.
> 
> It looks likely, but if you have the confirmation somewhere, it would
> help to link that too.
> 
> Or did I miss it?

I have no idea why I couldn't find the reply from lore.kernel.org/lkml/
The message id was 89e2b66b-c706-c020-bff5-b815dcd5c461@...el.com
in the thread(https://lore.kernel.org/lkml/20210520083144.GD14190@xsang-OptiPlex-9020/)

Xing, Zhengjun zhengjun.xing@...el.com confirmed 

Quote -
```
Hi Minchan,

...

I test the patch, the regression reduced to -2.9%.
```
Since then, I modified the patch a little more and couldn't find the
message from the public URL. Thus, do we need to confirm it again against
latest kernel?

Xing, could you confirm whether this patch fixes the regression?