lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Sep 2021 16:57:45 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Hans Verkuil <hverkuil-cisco@...all.nl>, linux-kernel@...r.kernel.org Cc: Sean Young <sean@...s.org>, linux-media@...r.kernel.org, Mauro Carvalho Chehab <mchehab+huawei@...nel.org> Subject: Re: [PATCH] media: rc and cec: keep all menu entries together On 9/20/21 4:19 AM, Hans Verkuil wrote: > Hi Randy, > > On 22/08/2021 02:04, Randy Dunlap wrote: >> Keep all of the Remote Controller and CEC menu entries grouped >> together. This is most relevant to 'make xconfig', where the >> entries for "HDMI CEC RC integration" and "Enable CEC error injection >> support" are not displayed (presented) anywhere near the other >> Remote Controller support options. >> By grouping all of these menu entries inside a menu/endmenu block, >> they are forced to be kept together. >> >> Fixes: 46d2a3b964dd ("media: place CEC menu before MEDIA_SUPPORT") >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org> >> Cc: Sean Young <sean@...s.org> >> Cc: Hans Verkuil <hverkuil-cisco@...all.nl> >> Cc: linux-media@...r.kernel.org >> Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org> >> --- >> drivers/media/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> --- linux-next-20210820.orig/drivers/media/Kconfig >> +++ linux-next-20210820/drivers/media/Kconfig >> @@ -6,8 +6,10 @@ >> # >> # NOTE: CEC and Remote Controller support should not depend on MEDIA_SUPPORT >> # >> +menu "Remote Controller and CEC support" >> source "drivers/media/rc/Kconfig" >> source "drivers/media/cec/Kconfig" >> +endmenu > > Remote control and CEC really have very little to do with one another, except > for "HDMI CEC RC integration", which is a feature of CEC. > > It would make more sense IMHO to make a "CEC support" menu and move the > CEC drivers and "HDMI CEC RC integration" and "Enable CEC error injection > support" to that new menu. It's a bit odd that those two CEC options are > directly under the Device Drivers menu. > > Would that work for you? > Hi Hans, I don't know, but I'll try it out. Thanks. > >> >> menuconfig MEDIA_SUPPORT >> tristate "Multimedia support" >> > -- ~Randy
Powered by blists - more mailing lists