linux-kernel - Re: [PATCH v4 02/13] dt-bindings: memory: mediatek: Add mt8195 smi sub common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUpCWib8Tpf0wfif@robh.at.kernel.org>
Date:   Tue, 21 Sep 2021 15:36:42 -0500
From:   Rob Herring <robh@...nel.org>
To:     Yong Wu <yong.wu@...iatek.com>
Cc:     Ikjoon Jang <ikjn@...omium.org>,
        Krzysztof Kozlowski <krzk@...nel.org>, youlin.pei@...iatek.com,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        devicetree@...r.kernel.org, Joerg Roedel <joro@...tes.org>,
        linux-kernel@...r.kernel.org, yi.kuo@...iatek.com,
        anan.sun@...iatek.com, Tomasz Figa <tfiga@...omium.org>,
        ming-fan.chen@...iatek.com,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        Will Deacon <will@...nel.org>, srv_heupstream@...iatek.com,
        linux-mediatek@...ts.infradead.org,
        iommu@...ts.linux-foundation.org, Rob Herring <robh+dt@...nel.org>,
        anthony.huang@...iatek.com, Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH v4 02/13] dt-bindings: memory: mediatek: Add mt8195 smi
 sub common

On Tue, 14 Sep 2021 19:36:52 +0800, Yong Wu wrote:
> Add the binding for smi-sub-common. The SMI block diagram like this:
> 
>         IOMMU
>          |  |
>       smi-common
>   ------------------
>   |      ....      |
>  larb0           larb7   <-max is 8
> 
> The smi-common connects with smi-larb and IOMMU. The maximum larbs number
> that connects with a smi-common is 8. If the engines number is over 8,
> sometimes we use a smi-sub-common which is nearly same with smi-common.
> It supports up to 8 input and 1 output(smi-common has 2 output)
> 
> Something like:
> 
>         IOMMU
>          |  |
>       smi-common
>   ---------------------
>   |      |          ...
> larb0  sub-common   ...   <-max is 8
>       -----------
>        |    |    ...   <-max is 8 too.
>      larb2 larb5
> 
> We don't need extra SW setting for smi-sub-common, only the sub-common has
> special clocks need to enable when the engines access dram.
> 
> If it is sub-common, it should have a "mediatek,smi" phandle to point to
> its smi-common. meanwhile the sub-common only has one gals clock.
> 
> Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> ---
> change note: add "else mediatek,smi: false".
> ---
>  .../mediatek,smi-common.yaml                  | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 

Reviewed-by: Rob Herring <robh@...nel.org>