linux-kernel - Re: [PATCH] pkcs7: support EC-RDSA/streebog in SignerInfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6318b58cf9ede0ffcda396cd14572d0143f6a04e.camel@kernel.org>
Date:   Wed, 22 Sep 2021 00:07:25 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>,
        Elvira Khabirova <e.khabirova@....ru>, keyrings@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au,
        dhowells@...hat.com, vt@...linux.org
Subject: Re: [PATCH] pkcs7: support EC-RDSA/streebog in SignerInfo

On Sat, 2021-09-18 at 10:39 +0800, Tianjia Zhang wrote:
> ping.
> 
> On 5/11/21 10:47 PM, Elvira Khabirova wrote:
> > Allow using EC-RDSA/streebog in pkcs7 certificates in a similar way
> > to how it's done in the x509 parser.
> > 
> > This is needed e.g. for loading kernel modules signed with EC-RDSA.
> > 
> > Signed-off-by: Elvira Khabirova <e.khabirova@....ru>
> > ---
> >   crypto/asymmetric_keys/pkcs7_parser.c | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> > 
> > diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c
> > index 967329e0a07b..39c260a04167 100644
> > --- a/crypto/asymmetric_keys/pkcs7_parser.c
> > +++ b/crypto/asymmetric_keys/pkcs7_parser.c
> > @@ -248,6 +248,12 @@ int pkcs7_sig_note_digest_algo(void *context, size_t hdrlen,
> >   	case OID_sha224:
> >   		ctx->sinfo->sig->hash_algo = "sha224";
> >   		break;
> > +	case OID_gost2012Digest256:
> > +		ctx->sinfo->sig->hash_algo = "streebog256";
> > +		break;
> > +	case OID_gost2012Digest512:
> > +		ctx->sinfo->sig->hash_algo = "streebog512";
> > +		break;
> >   	default:
> >   		printk("Unsupported digest algo: %u\n", ctx->last_oid);
> >   		return -ENOPKG;
> > @@ -269,6 +275,11 @@ int pkcs7_sig_note_pkey_algo(void *context, size_t hdrlen,
> >   		ctx->sinfo->sig->pkey_algo = "rsa";
> >   		ctx->sinfo->sig->encoding = "pkcs1";
> >   		break;
> > +	case OID_gost2012PKey256:
> > +	case OID_gost2012PKey512:
> > +		ctx->sinfo->sig->pkey_algo = "ecrdsa";
> > +		ctx->sinfo->sig->encoding = "raw";
> > +		break;
> >   	default:
> >   		printk("Unsupported pkey algo: %u\n", ctx->last_oid);
> >   		return -ENOPKG;
> > 

Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

/Jarkko