linux-kernel - RE: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Sep 2021 21:34:34 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>,
        Sean Christopherson <seanjc@...gle.com>,
        "Hansen, Dave" <dave.hansen@...el.com>
CC:     "Zhang, Cathy" <cathy.zhang@...el.com>,
        "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 1/7] x86/sgx: Provide indication of life-cycle of EPC
 pages

>> Since there are multiple uses of the "owner" field with different types
>> change the sgx_epc_page structure to define an anonymous union with
>> each of the uses explicitly called out.
>
> But it's still always a pointer.
>
> And not only that, but two alternative fields in that union have *exactly* the
> same type, so it's kind of artifically representing the problem more complex
> than it really is.

Bother! I seem to have jumbled some old bits of v4 into this series.

I agree that we just want "void *owner; here.  I even made the changes.
Then managed to lose them while updating.

I'll find the bits I lost and re-merge them in.

-Tony