linux-kernel - Re: [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d4469be4fa79adaa0a60f42f48bafda@codeaurora.org>
Date:   Tue, 21 Sep 2021 11:53:26 +0530
From:   rajpat@...eaurora.org
To:     Doug Anderson <dianders@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>,
        msavaliy@....qualcomm.com, satya priya <skakit@...eaurora.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support

On 2021-09-18 01:32, Doug Anderson wrote:
> Hi,
> 
> On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <rajpat@...eaurora.org> 
> wrote:
>> 
>> Add compatible for sc7280 SoC.
>> 
>> Signed-off-by: Rajesh Patil <rajpat@...eaurora.org>
>> ---
>> Changes in V8:
>>  - As per Doug's comments, added "qcom,sc7280-qspi" compatible
>> 
>>  Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 
>> ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml 
>> b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> index ef5698f..31711fe 100644
>> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> @@ -21,7 +21,10 @@ allOf:
>>  properties:
>>    compatible:
>>      items:
>> -      - const: qcom,sdm845-qspi
>> +      - enum:
>> +        - qcom,sdm845-qspi
>> +        - qcom,sc7280-qspi
> 
> Other than the fact that the indentation is wrong (as Rob's bot
> found), this looks good to me. Feel free to add my Reviewed-by when
> you fix the indentation. In theory you could also be nice and add the
> sc7180-qspi at the same time, I think.
> 
> -Doug

Adding dt-bindings for sc7180 will send in the follow-up patches.