linux-kernel - Re: [PATCH v4 5/6] iova: Add iova_len argument to init_iova

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4add7fb2-e9de-9c15-1915-6a6e2596941d@huawei.com>
Date:   Tue, 21 Sep 2021 09:48:51 +0100
From:   John Garry <john.garry@...wei.com>
To:     Robin Murphy <robin.murphy@....com>, Will Deacon <will@...nel.org>
CC:     <joro@...tes.org>, <baolu.lu@...ux.intel.com>,
        <iommu@...ts.linux-foundation.org>, <linuxarm@...wei.com>,
        <thierry.reding@...il.com>, <airlied@...ux.ie>, <daniel@...ll.ch>,
        <jonathanh@...dia.com>, <sakari.ailus@...ux.intel.com>,
        <bingbu.cao@...el.com>, <tian.shu.qiu@...el.com>,
        <mchehab@...nel.org>, <gregkh@...uxfoundation.org>,
        <digetx@...il.com>, <mst@...hat.com>, <jasowang@...hat.com>,
        <linux-kernel@...r.kernel.org>, <chenxiang66@...ilicon.com>
Subject: Re: [PATCH v4 5/6] iova: Add iova_len argument to init_iova_domain()

On 02/08/2021 17:16, Robin Murphy wrote:
>>>>
>>>> Also fix up all users to set this value (at 0, meaning use default).
>>> Wrap that in init_iova_domain_defaults() to avoid the mysterious 0?
>>
>> Sure, I can do something like that. I actually did have separate along 
>> those lines in v3 before I decided to change it.
> 
> Y'know, at this point I'm now starting to seriously wonder whether 
> moving the rcaches into iommu_dma_cookie wouldn't make a whole lot of 
> things simpler... :/
> 
> Does that sound like crazy talk to you, or an idea worth entertaining?

Hi Robin,

JFYI, to try to make inroads into my IOVA issues, I'm going to look to 
do this first, if you don't mind. I think that the fq stuff can also be 
put into a separate structure also, rather than iova_domain, and that 
can also be a member of iommu_dma_cookie.

BTW, with regards to separating the rcache magazine code out, I see 
someone already trying to introduce something similar:

https://lore.kernel.org/lkml/CAKW4uUxperg41z8Lu5QYsS-YEGt1anuD1CuiUqXC0ANFqJBosQ@mail.gmail.com/T/#me4cc5de775ad16ab3d6e7ca854b55f274ddcba08

https://lore.kernel.org/lkml/YUkErK1vVZMht4s8@casper.infradead.org/T/#t

Cheers,
John