linux-kernel - Re: [PATCH v1] arm64: dts: qcom: sc7180-trogdor: Enable IPA on LTE only SKUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f94de2e-eb1b-225e-937d-55855d95a4ac@linaro.org>
Date:   Mon, 20 Sep 2021 14:45:33 -0500
From:   Alex Elder <elder@...aro.org>
To:     Sujit Kautkar <sujitka@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     swboyd@...omium.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180-trogdor: Enable IPA on LTE
 only SKUs

On 9/20/21 1:32 PM, Sujit Kautkar wrote:
> Enable the IPA node for LTE and skip for wifi-only SKUs
> 
> Signed-off-by: Sujit Kautkar <sujitka@...omium.org>

Looks good to me.  Thanks Sujit.

Reviewed-by: Alex Elder <elder@...aro.org>

> ---
> 
>   arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 11 +++++++++++
>   arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi         | 11 -----------
>   2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
> index 469aad4e5948c..fd4b712037542 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi
> @@ -17,3 +17,14 @@ &remoteproc_mpss {
>   	firmware-name = "qcom/sc7180-trogdor/modem/mba.mbn",
>   			"qcom/sc7180-trogdor/modem/qdsp6sw.mbn";
>   };
> +
> +&ipa {
> +	status = "okay";
> +
> +	/*
> +	 * Trogdor doesn't have QHEE (Qualcomm's EL2 blob), so the
> +	 * modem needs to cover certain init steps (GSI init), and
> +	 * the AP needs to wait for it.
> +	 */
> +	modem-init;
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 6e96024a487cd..3d8b9c6b21a85 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -754,17 +754,6 @@ alc5682: codec@1a {
>   	};
>   };
>   
> -&ipa {
> -	status = "okay";
> -
> -	/*
> -	 * Trogdor doesn't have QHEE (Qualcomm's EL2 blob), so the
> -	 * modem needs to cover certain init steps (GSI init), and
> -	 * the AP needs to wait for it.
> -	 */
> -	modem-init;
> -};
> -
>   &lpass_cpu {
>   	status = "okay";
>   
>