linux-kernel - Re: [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9049e956-2865-7309-2eaf-aa4516ab28d6@kernel.org>
Date:   Tue, 21 Sep 2021 12:52:38 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Andreas Koensgen <ajk@...nets.uni-bremen.de>,
        Paul Mackerras <paulus@...ba.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Subject: Re: [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and
 compat_ioctl

On 21. 09. 21, 6:00, Dmitry Torokhov wrote:
> Hi Jiri,
> 
> On Tue, Sep 14, 2021 at 11:11:25AM +0200, Jiri Slaby wrote:
>> diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c
>> index 17eb8f2aa48d..55e91d0e70ec 100644
>> --- a/drivers/input/serio/serport.c
>> +++ b/drivers/input/serio/serport.c
>> @@ -207,8 +207,8 @@ static void serport_set_type(struct tty_struct *tty, unsigned long type)
>>    * serport_ldisc_ioctl() allows to set the port protocol, and device ID
>>    */
>>   
>> -static int serport_ldisc_ioctl(struct tty_struct *tty, struct file *file,
>> -			       unsigned int cmd, unsigned long arg)
>> +static int serport_ldisc_ioctl(struct tty_struct *tty, unsigned int cmd,
>> +		unsigned long arg)
> 
> Can we please keep arguments aligned as they were? Otherwise

Fixed, thanks. Likely, I will send a follow-up -- depending if Greg 
drops or keeps these in the tree.

-- 
js
suse labs