linux-kernel - Re: [PATCH] [PATCH v2] misc: fastrpc: fix improper packet size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4b294b251ed5ae4d7062edebcb397c1@codeaurora.org>
Date:   Tue, 21 Sep 2021 17:05:29 +0530
From:   jeyr@...eaurora.org
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-arm-msm@...r.kernel.org, srinivas.kandagatla@...aro.org,
        linux-kernel@...r.kernel.org, fastrpc.upstream@....qualcomm.com
Subject: Re: [PATCH] [PATCH v2] misc: fastrpc: fix improper packet size
 calculation

On 2021-09-21 17:02, Greg KH wrote:
> On Tue, Sep 21, 2021 at 04:27:27PM +0530, Jeya R wrote:
>> The buffer list is sorted and this is not being considered while
>> calculating packet size. This would lead to improper copy length
>> calculation for non-dmaheap buffers which would eventually cause
>> sending improper buffers to DSP.
>> 
>> Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke 
>> method")
>> Signed-off-by: Jeya R <jeyr@...eaurora.org>
>> 
>> Changes in v2:
>> - updated commit message to proper format
>> - added fixes tag to commit message
>> - removed unnecessary variable initialization
>> - removed length check during payload calculation
>> ---
>>  drivers/misc/fastrpc.c | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> The "Changes" need to go below the --- line, as the documentation 
> states
> to do.
> 
> thanks,
> 
> greg k-h
Thanks Greg for your comment. Will resend PATCH 2 to address this.