linux-kernel - Re: [RESEND PATCH v2] misc: fastrpc: fix improper packet size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YUnG9j1j9EmcocJ1@kroah.com>
Date:   Tue, 21 Sep 2021 13:50:14 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jeya R <jeyr@...eaurora.org>
Cc:     linux-arm-msm@...r.kernel.org, srinivas.kandagatla@...aro.org,
        linux-kernel@...r.kernel.org, fastrpc.upstream@....qualcomm.com
Subject: Re: [RESEND PATCH v2] misc: fastrpc: fix improper packet size
 calculation

On Tue, Sep 21, 2021 at 05:03:01PM +0530, Jeya R wrote:
> The buffer list is sorted and this is not being considered while
> calculating packet size. This would lead to improper copy length
> calculation for non-dmaheap buffers which would eventually cause
> sending improper buffers to DSP.
> 
> Fixes: c68cfb718c8f ("misc: fastrpc: Add support for context Invoke method")
> Signed-off-by: Jeya R <jeyr@...eaurora.org>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> Changes in v2:
> - updated commit message to proper format
> - added fixes tag to commit message
> - removed unnecessary variable initialization
> - removed length check during payload calculation
> ---
>  drivers/misc/fastrpc.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Again, please read the documentation, changes go below the --- line.

I am _SURE_ there is a guide somewhere at your employer for how to do
all of this properly, right?

thanks,

greg k-h