linux-kernel - Re: [PATCH 0/6] Get rid of pm_runtime_irq_safe() for 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vef_Y8M9RmpCvfpo9OWC4Nt3rzV7S9esJBcub_5DZQj1Q@mail.gmail.com>
Date:   Tue, 21 Sep 2021 15:03:39 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Johan Hovold <johan@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/6] Get rid of pm_runtime_irq_safe() for 8250_omap

On Tue, Sep 21, 2021 at 1:34 PM Tony Lindgren <tony@...mide.com> wrote:
>
> Hi,
>
> Here are patches to get rid of pm_runtime_irq_safe() for the 8250_omap
> driver.
>
> For removing the pm_runtime_irq_safe() usage, serial TX is the last
> remaining issue. We deal with TX by waking up the port and returning 0
> bytes written from write_room() and write() if the port is not available
> because of PM runtime autoidle.

of the PM

>
> This series also removes the dependency to Andy's pending generic serial
> layer PM runtime patches, and hopefully makes that work a bit easier :)


Thank you, Tony, very much! The series looks to me in a good
condition, hence, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Regards,
>
> Tony
>
>
> Tony Lindgren (6):
>   n_tty: Start making use of -EAGAIN returned from
>     process_output_block()
>   tty: n_gsm: Don't ignore write return value in gsmld_output()
>   serial: core: Add new prep_tx for power management
>   serial: 8250: Implement prep_tx for power management
>   serial: 8250_omap: Require a valid wakeirq for deeper idle states
>   serial: 8250_omap: Drop the use of pm_runtime_irq_safe()
>
>  Documentation/driver-api/serial/driver.rst |  9 ++++++
>  drivers/tty/n_gsm.c                        |  5 ++-
>  drivers/tty/n_tty.c                        |  8 +++--
>  drivers/tty/serial/8250/8250_omap.c        | 36 +++++++++++++++-------
>  drivers/tty/serial/8250/8250_port.c        | 24 +++++++++++++++
>  drivers/tty/serial/serial_core.c           | 23 ++++++++++++++
>  include/linux/serial_core.h                |  1 +
>  7 files changed, 90 insertions(+), 16 deletions(-)
>
> --
> 2.33.0



-- 
With Best Regards,
Andy Shevchenko