linux-kernel - Re: [PATCH 2/2] mm: Move fold_vm_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Sep 2021 13:33:19 +0100
From:   Mel Gorman <mgorman@...e.de>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Matt Fleming <matt@...eblueprint.co.uk>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, Gon Solo <gonsolo@...il.com>,
        linux-mm@...ck.org, linux-sh@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: Move fold_vm_numa_events() to fix NUMA without
 SMP

On Thu, Sep 16, 2021 at 10:42:43AM +0200, Geert Uytterhoeven wrote:
> If CONFIG_NUMA=y, but CONFIG_SMP=n (e.g. sh/migor_defconfig):
> 
>     sh4-linux-gnu-ld: mm/vmstat.o: in function `vmstat_start':
>     vmstat.c:(.text+0x97c): undefined reference to `fold_vm_numa_events'
>     sh4-linux-gnu-ld: drivers/base/node.o: in function `node_read_vmstat':
>     node.c:(.text+0x140): undefined reference to `fold_vm_numa_events'
>     sh4-linux-gnu-ld: drivers/base/node.o: in function `node_read_numastat':
>     node.c:(.text+0x1d0): undefined reference to `fold_vm_numa_events'
> 
> Fix this by moving fold_vm_numa_events() outside the SMP-only section.
> 
> Fixes: f19298b9516c1a03 ("mm/vmstat: convert NUMA statistics to basic NUMA counters")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Mel Gorman <mgorman@...e.de>

-- 
Mel Gorman
SUSE Labs