linux-kernel - Re: [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Sep 2021 14:50:52 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Matan Ziv-Av <matan@...alib.org>,
        Mark Gross <mgross@...ux.intel.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 1/2] platform: lg-laptop: drop unneeded MODULE_ALIAS

Hi,

On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for ACPI driver.
> Having another MODULE_ALIAS causes the alias to be duplicated.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/lg-laptop.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
> index 3e520d5bca07..4f3ece819f4c 100644
> --- a/drivers/platform/x86/lg-laptop.c
> +++ b/drivers/platform/x86/lg-laptop.c
> @@ -60,7 +60,6 @@ MODULE_ALIAS("wmi:" WMI_EVENT_GUID2);
>  MODULE_ALIAS("wmi:" WMI_EVENT_GUID3);
>  MODULE_ALIAS("wmi:" WMI_METHOD_WMAB);
>  MODULE_ALIAS("wmi:" WMI_METHOD_WMBB);
> -MODULE_ALIAS("acpi*:LGEX0815:*");
>  
>  static struct platform_device *pf_device;
>  static struct input_dev *wmi_input_dev;
>