linux-kernel - Re: [PATCH v1 2/4] soc: samsung: change SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABYd82YhCzLL8Bs0bMtC9cTFETtbKn8S1NXnP_254vHwzi4E3g@mail.gmail.com>
Date:   Mon, 20 Sep 2021 13:57:55 -0700
From:   Will McVicker <willmcvicker@...gle.com>
To:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        "Cc: Android Kernel" <kernel-team@...roid.com>,
        linux-arm-kernel@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic

On Mon, Sep 20, 2021 at 12:04 PM Will McVicker <willmcvicker@...gle.com> wrote:
>
> Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to
> be enabled by default via "default y if ARCH_EXYNOS" versus being
> selected by the ARCH_EXYNOS config directly. This allows vendors to
> disable these configs if they wish and provides additional flexibility
> to modularize them in the presence of a generic kernel.
>
> There are no .config differences with this change. The configs
> SOC_SAMSUNG, EXYNOS_CHIPID, EXYNOS_PM_DOMAINS, and EXYNOS_PMU still
> remain enabled by default.
>
> Signed-off-by: Will McVicker <willmcvicker@...gle.com>
> ---
>  arch/arm64/Kconfig.platforms | 4 ----
>  drivers/soc/samsung/Kconfig  | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 3a66ed43088d..6a006490c9b9 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -91,14 +91,10 @@ config ARCH_BRCMSTB
>
>  config ARCH_EXYNOS
>         bool "ARMv8 based Samsung Exynos SoC family"
> -       select EXYNOS_CHIPID
> -       select EXYNOS_PM_DOMAINS if PM_GENERIC_DOMAINS
> -       select EXYNOS_PMU
>         select HAVE_S3C_RTC if RTC_CLASS
>         select PINCTRL
>         select PINCTRL_EXYNOS
>         select PM_GENERIC_DOMAINS if PM
> -       select SOC_SAMSUNG
>         help
>           This enables support for ARMv8 based Samsung Exynos SoC family.
>
> diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
> index 5745d7e5908e..9402c02bc9de 100644
> --- a/drivers/soc/samsung/Kconfig
> +++ b/drivers/soc/samsung/Kconfig
> @@ -4,6 +4,7 @@
>  #
>  menuconfig SOC_SAMSUNG
>         bool "Samsung SoC driver support" if COMPILE_TEST
> +       default y if ARCH_EXYNOS
>
>  if SOC_SAMSUNG
>
> @@ -15,6 +16,7 @@ config EXYNOS_ASV_ARM
>  config EXYNOS_CHIPID
>         bool "Exynos ChipID controller and ASV driver" if COMPILE_TEST
>         depends on ARCH_EXYNOS || COMPILE_TEST
> +       default y if ARCH_EXYNOS
>         select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS
>         select MFD_SYSCON
>         select SOC_BUS
> @@ -24,6 +26,7 @@ config EXYNOS_CHIPID
>  config EXYNOS_PMU
>         bool "Exynos PMU controller driver" if COMPILE_TEST
>         depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST)
> +       default y if ARCH_EXYNOS
>         select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS
>
>  # There is no need to enable these drivers for ARMv8
> @@ -34,6 +37,7 @@ config EXYNOS_PMU_ARM_DRIVERS
>  config EXYNOS_PM_DOMAINS
>         bool "Exynos PM domains" if COMPILE_TEST
>         depends on (ARCH_EXYNOS && PM_GENERIC_DOMAINS) || COMPILE_TEST
> +       default y if (ARCH_EXYNOS && PM_GENERIC_DOMAINS)
>
>  config SAMSUNG_PM_DEBUG
>         bool "Samsung PM Suspend debug"
> --
> 2.33.0.464.g1972c5931b-goog
>

Sorry I didn't see this patch sent yesterday:
https://lore.kernel.org/lkml/CAGOxZ50i6URzUQ7o7V4m7MR=2TqSeD6qx5fQaQDs+5nEq4fa2A@mail.gmail.com/

Looks like Krzysztof's patch covers my portion of the patch related to
EXYNOS_CHIPID. I'll keep an eye on his patch as it goes through and
will modify mine as needed since it's likely to come in after.

Thanks,
Will