linux-kernel - Re: [PATCH 0/2] Use generic code for virtual address of randomization of x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EB3D825-264D-447A-8C55-FA0CE8BC31F6@chromium.org>
Date:   Tue, 21 Sep 2021 06:24:07 -0700
From:   Kees Cook <keescook@...omium.org>
To:     sxwjean@...com, x86@...nel.org, linux-mm@...ck.org
CC:     Xiongwei Song <sxwjean@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Gabriel Krisman Bertazi <krisman@...labora.com>,
        "Chang S. Bae" <chang.seok.bae@...el.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Balbir Singh <sblbir@...zon.com>, Jens Axboe <axboe@...nel.dk>,
        Lai Jiangshan <laijs@...ux.alibaba.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Kim Phillips <kim.phillips@....com>,
        Yazen Ghannam <yazen.ghannam@....com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Stefan Metzmacher <metze@...ba.org>,
        Marco Elver <elver@...gle.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] Use generic code for virtual address of randomization of x86



On September 21, 2021 4:02:50 AM PDT, sxwjean@...com wrote:
>From: Xiongwei Song <sxwjean@...il.com>
>
>Hello,
>
>The two patches are to use generic code for randomization of virtual
>address of x86. Since the basic code logic of x86 is same as generic
>code, so no need to implement these functions on x86, please see the
>details in comments of patch 2.

Hi!

The other patches do not seem to have arrived; I only see 0/2.

-Kees

>
>Please review it.
>
>Cc: Thomas Gleixner <tglx@...utronix.de>
>Cc: Ingo Molnar <mingo@...hat.com>
>Cc: Borislav Petkov <bp@...en8.de>
>Cc: "H. Peter Anvin" <hpa@...or.com>
>Cc: Andy Lutomirski <luto@...nel.org>
>Cc: Gabriel Krisman Bertazi <krisman@...labora.com>
>Cc: "Chang S. Bae" <chang.seok.bae@...el.com>
>Cc: Al Viro <viro@...iv.linux.org.uk>
>Cc: Arvind Sankar <nivedita@...m.mit.edu>
>Cc: Alexey Dobriyan <adobriyan@...il.com>
>Cc: Oleg Nesterov <oleg@...hat.com>
>Cc: Balbir Singh <sblbir@...zon.com>
>Cc: Jens Axboe <axboe@...nel.dk>
>Cc: Lai Jiangshan <laijs@...ux.alibaba.com>
>Cc: Dave Hansen <dave.hansen@...ux.intel.com>
>Cc: Peter Zijlstra <peterz@...radead.org>
>Cc: Andrew Morton <akpm@...ux-foundation.org>
>Cc: Arnd Bergmann <arnd@...db.de>
>Cc: "David S. Miller" <davem@...emloft.net>
>Cc: Kees Cook <keescook@...omium.org>
>Cc: Kim Phillips <kim.phillips@....com>
>Cc: Yazen Ghannam <yazen.ghannam@....com>
>Cc: Davidlohr Bueso <dave@...olabs.net>
>Cc: Stefan Metzmacher <metze@...ba.org>
>Cc: Marco Elver <elver@...gle.com>
>Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
>Cc: Christophe Leroy <christophe.leroy@...roup.eu>
>Cc: linux-kernel@...r.kernel.org
>
>Xiongwei Song (2):
>  x86: Rename TIF_ADDR32 to TIF_32BIT
>  x86/mm: Randomize va with generic arch_pick_mmap_layout()
>
> arch/x86/Kconfig                     |   2 +-
> arch/x86/include/asm/compat.h        |   7 +-
> arch/x86/include/asm/elf.h           |   2 +-
> arch/x86/include/asm/page_64_types.h |   6 +-
> arch/x86/include/asm/processor.h     |   4 +-
> arch/x86/include/asm/thread_info.h   |   4 +-
> arch/x86/kernel/process.c            |   5 --
> arch/x86/kernel/process_64.c         |   4 +-
> arch/x86/mm/mmap.c                   | 112 ---------------------------
> include/linux/compat.h               |   4 +
> mm/util.c                            |  18 ++++-
> 11 files changed, 37 insertions(+), 131 deletions(-)
>