linux-kernel - Re: [PATCH v3 2/3] ASoC: Use schema reference for sound-name-prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2d8aede-94b1-2658-a465-5f67795c5725@nvidia.com>
Date:   Tue, 21 Sep 2021 20:45:10 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Rob Herring <robh+dt@...nel.org>
CC:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Jerome Brunet <jbrunet@...libre.com>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] ASoC: Use schema reference for sound-name-prefix



On 9/20/2021 6:27 PM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, Sep 3, 2021 at 11:36 AM Sameer Pujar <spujar@...dia.com> wrote:
>> Use schema reference for 'sound-name-prefix' property wherever
>> necessary.
>>
>> Signed-off-by: Sameer Pujar <spujar@...dia.com>
>> Cc: Jerome Brunet <jbrunet@...libre.com>
>> Cc: Stephan Gerhold <stephan@...hold.net>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Reviewed-by: Jerome Brunet <jbrunet@...libre.com>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> ---
> [...]
>
>> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>> index ffb8fcf..68e5ad2 100644
>> --- a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>> @@ -9,6 +9,9 @@ title: NXP/Goodix TFA989X (TFA1) Audio Amplifiers
>>   maintainers:
>>     - Stephan Gerhold <stephan@...hold.net>
>>
>> +allOf:
>> +  - $ref: name-prefix.yaml#
>> +
>>   properties:
>>     compatible:
>>       enum:
>> @@ -21,12 +24,6 @@ properties:
>>     '#sound-dai-cells':
>>       const: 0
>>
>> -  sound-name-prefix:
> You can't remove the property. This is now a warning in linux-next:
>
> Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml:
> audio-codec@34: 'sound-name-prefix' does not match any of the regexes:
> 'pinctrl-[0-9]+'
>   From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml:
> audio-codec@36: 'sound-name-prefix' does not match any of the regexes:
> 'pinctrl-[0-9]+'
>   From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>
>
> Just 'sound-name-prefix: true' is fine

I will push a fix for this.