linux-kernel - Re: [PATCH V9 1/8] dt-bindings: spi: Add sc7280 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163224787559.763609.17193788799229852583@swboyd.mtv.corp.google.com>
Date:   Tue, 21 Sep 2021 11:11:15 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rajesh Patil <rajpat@...eaurora.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, rnayak@...eaurora.org,
        saiprakash.ranjan@...eaurora.org, msavaliy@....qualcomm.com,
        skakit@...eaurora.org, mka@...omium.org, dianders@...omium.org,
        Rajesh Patil <rajpat@...eaurora.org>
Subject: Re: [PATCH V9 1/8] dt-bindings: spi: Add sc7280 support

Quoting Rajesh Patil (2021-09-21 03:38:59)
> Add compatible for sc7280 SoC.
> 
> Signed-off-by: Rajesh Patil <rajpat@...eaurora.org>
> Reviewed-by: Doug Anderson <dianders@...omium.org>
> ---

One nit below

Reviewed-by: Stephen Boyd <swboyd@...omium.org>

> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> index ef5698f..1c8b2ea 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> @@ -21,7 +21,10 @@ allOf:
>  properties:
>    compatible:
>      items:
> -      - const: qcom,sdm845-qspi
> +      - enum:
> +          - qcom,sdm845-qspi
> +          - qcom,sc7280-qspi

Would be nice to keep this alphabet sorted too.

> +
>        - const: qcom,qspi-v1
>  
>    reg: