linux-kernel - Re: [PATCH] media: vsp1: Make use of the helper function devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YUuyjEibbug/Taal@pendragon.ideasonboard.com>
Date:   Thu, 23 Sep 2021 01:47:40 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: vsp1: Make use of the helper function
 devm_platform_ioremap_resource()

Hi Cai,

Thank you for the patch.

On Wed, Sep 01, 2021 at 01:57:08PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/platform/vsp1/vsp1_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c
> index de442d6c9926..8acd6d45d8d0 100644
> --- a/drivers/media/platform/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/vsp1/vsp1_drv.c
> @@ -785,7 +785,6 @@ static int vsp1_probe(struct platform_device *pdev)
>  	struct vsp1_device *vsp1;
>  	struct device_node *fcp_node;
>  	struct resource *irq;
> -	struct resource *io;
>  	unsigned int i;
>  	int ret;
>  
> @@ -800,8 +799,7 @@ static int vsp1_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, vsp1);
>  
>  	/* I/O and IRQ resources (clock managed by the clock PM domain). */
> -	io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	vsp1->mmio = devm_ioremap_resource(&pdev->dev, io);
> +	vsp1->mmio = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(vsp1->mmio))
>  		return PTR_ERR(vsp1->mmio);
>  

-- 
Regards,

Laurent Pinchart